News: 0001585428

  ARM Give a man a fire and he's warm for a day, but set fire to him and he's warm for the rest of his life (Terry Pratchett, Jingo)

New Code Merged For Linux 6.18 To Address Linus Torvalds' Rust Formatting Critique

([Linux Kernel] 77 Minutes Ago rustfmt)


Back during the Linux 6.18 merge window Linus Torvalds commented on " [1]mindless and completely crazy Rust format checking " and that the RUst format checking "is all bass-ackwards garbage" with condensing multi-line import statements into single lines. Merged minutes ago to Linux Git ahead of tomorrow's Linux 6.18-rc2 are fixes to the Rust format checking and updated guidelines to address Torvalds' criticism.

Rust for Linux lead developer Miguel Ojeda commented with today's Rust for Linux 6.18 updates that have been [2]merged :

"Rust 'rustfmt' cleanup

'rustfmt', by default, formats imports in a way that is prone to conflicts while merging and rebasing, since in some cases it condenses several items into the same line.

Document in our guidelines that we will handle this for the moment with the trailing empty comment workaround and make the tree 'rustfmt'-clean again"

The rustfmt update and updated guidance in the documentation should address the criticism raised by Torvalds back during the Linux 6.18 merge window to make the Rust code smoother moving forward:

Look for this clean-up in tomorrow's Linux 6.18-rc2 release.



[1] https://www.phoronix.com/news/Linus-Torvalds-Rust-Formatting

[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=1c64efcb083c48c85227cb4d72ab137feef2cdac


"Speak, thou vast and venerable head," muttered Ahab, "which, though
ungarnished with a beard, yet here and there lookest hoary with mosses; speak,
mighty head, and tell us the secret thing that is in thee. Of all divers,
thou has dived the deepest. That head upon which the upper sun now gleams has
moved amid the world's foundations. Where unrecorded names and navies rust,
and untold hopes and anchors rot; where in her murderous hold this frigate
earth is ballasted with bones of millions of the drowned; there, in that awful
water-land, there was thy most familiar home. Thou hast been where bell or
diver never went; has slept by many a sailer's side, where sleepless mothers
would give their lives to lay them down. Thou saw'st the locked lovers when
leaping from their flaming ship; heart to heart they sank beneath the exulting
wave; true to each other, when heaven seemed false to them. Thou saw'st the
murdered mate when tossed by pirates from the midnight deck; for hours he fell
into the deeper midnight of the insatiate maw; and his murderers still sailed
on unharmed -- while swift lightnings shivered the neighboring ship that would
have borne a righteous husband to outstretched, longing arms. O head! thou has
seen enough to split the planets and make an infidel of Abraham, and not one
syllable is thine!"
-- H. Melville, "Moby Dick"