Linus Torvalds Gently Criticizes Build-Slowing Testing Code Left in Linux 6.15-rc1 (phoronix.com)
- Reference: 0176869683
- News link: https://linux.slashdot.org/story/25/03/31/0430218/linus-torvalds-gently-criticizes-build-slowing-testing-code-left-in-linux-615-rc1
- Source link: https://www.phoronix.com/news/Linux-6.15-hdrtest-Turd
> The new "hdrtest" code is for the Intel Xe kernel driver and is around trying to help ensure the Direct Rendering Manager header files are self-contained and pass kernel-doc tests — basic maintenance checks on the included DRM header files to ensure they are all in good shape.
But Torvalds [2]accused the code of not only slowing down the full-kernel builds, but also leaving behind "random" files for dependencies "that then make the source tree nasty," [3]reports Tom's Hardware :
> While Torvalds was disturbed by the code that was impacting the latest Linux kernel, beginning his post with a "Grr," he remained precise in his objections to it. "I did the pull, resolved the (trivial) conflicts, but I notice that this ended up containing the disgusting 'hdrtest' crap that (a) slows down the build because it's done for a regular allmodconfig build rather than be some simple thing that you guys can run as needed (b) also leaves random 'hdrtest' turds around in the include directories," he wrote.
>
> Torvalds went on to state that he had previously complained about this issue, and inquired why the hdr testing is being done as a regular part of the build. Moreover, he highlighted that the resulting 'turds' were breaking filename completion. Torvalds underlined this point — and his disgust — by stating, "this thing needs to *die*." In a shot of advice to fellow Linux developers, Torvalds said, "If you want to do that hdrtest thing, do it as part of your *own* checks. Don't make everybody else see that disgusting thing...."
>
> He then noted that he had decided to mark hdrtest as broken for now, to prevent its inclusion in regular builds.
As of Saturday, all of the DRM-Next code had made it into Linux 6.15 Git, [4]notes Phoronix . "But Linus Torvalds is expecting all this 'hdrtest' mess to be cleaned up."
[1] https://www.phoronix.com/news/Linux-6.15-hdrtest-Turd
[2] https://lore.kernel.org/dri-devel/174321011387.3019715.1646591159826097779.pr-tracker-bot@kernel.org/T/#ra42b2c08d4a646323cf1d0c5ef13ef2b4157c516
[3] https://www.tomshardware.com/software/linux/linus-torvalds-rages-against-random-turd-files-in-linux-6-15-rc1-directories
[4] https://www.phoronix.com/news/Linux-6.15-hdrtest-Turd
Regression in 15 (Score:1)
First, I like Phoronix and support Michael Larabel's many year effort.
Second, I like Linux and he speaks to truth which as a coder I appreciate.
I always run the latest release kernel, and sometimes the RC-5/6 branch.
This time I waited til 15. Sadly I also added a second monitor.
DRM is just a bear. It took several "set as primary monitor" "change resolution"
and "hard reboot" (soft would hang) to get things to were I could down downres the
max hardres the primary (laptop Dell 7xxx) and keep the backup (HP 24
Good (Score:2)
Looks like he's a responsible maintainer who questions and controls tech debt before it becomes a serious issue. Many people could learn from that.
So the gently part (Score:3)
Is the news?
Don't know about you, man (Score:2)
But to make your code stand out above the rest -- or should I say, under everybody's shoe -- won't be worth bragging points at the bar
Slow news day? (Score:2)
Why is this news? Something writes a pull request and their test routine isn't deemed to be clean code, so the pull request gets not accepted yet. This happens in thousands of projects every day. It's not like Linus fired the developer or something.
Re: (Score:2)
They will rewrite the Linux kernel from scratch within months!
A microkernel implementation (Score:4, Funny)
> They will rewrite the Linux kernel from scratch within months!
Awesome, looking forward to a microkernel implementation. :-)